-
Notifications
You must be signed in to change notification settings - Fork 277
DEV: beginning of Develop landing page redesign #1558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Staging links: |
|
@dwdougherty Really nice (and well done for getting so far so quickly)! All I would say is maybe we could add code styling and/or links on the command line suggestions, and maybe add an HGETALL to show the results of the HSET? Otherwise, more or less usable as it is. I know we don't ultimately want the standard Hugo list of other pages in the section here, but it might be OK for now, since you've finished your bit quicker than I finished mine :-) Maybe just a short "see the pages below to learn more about developing with Redis", or something, and then the list? If you'd rather just wait until all the changes are ready, then that's fine by me, but this is so neat, it's probably a worthwhile improvement just as it is. |
|
@andy-stark-redis Please take another look. |
|
@dwdougherty That's looking really good now! Maybe get Michelle's opinion too, but I'd say that's a neat improvement by itself, and mergeable right away :-) |
|
Hi @mich-elle-luna. These changes are the beginning of our work (@andy-stark-redis and yours truly) on a new landing page. Please take a look and let me know if it's okay to merge as is as an interim step while Andy completes the rest of the page. |
mich-elle-luna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
|
Thank you, @mich-elle-luna and @andy-stark-redis! |
DOC-5244
Add a Redis CLI widget to the top of the Develop page, kind of like the former IO page.
The changes to layouts/develop/list.html can go either before or after the
{{ .Content }}line. For any other placement, we'd need a custom (one-off) partial.