Skip to content

Conversation

@dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented May 13, 2025

DOC-5244

Add a Redis CLI widget to the top of the Develop page, kind of like the former IO page.

The changes to layouts/develop/list.html can go either before or after the {{ .Content }} line. For any other placement, we'd need a custom (one-off) partial.

@github-actions
Copy link
Contributor

@andy-stark-redis
Copy link
Contributor

@dwdougherty Really nice (and well done for getting so far so quickly)! All I would say is maybe we could add code styling and/or links on the command line suggestions, and maybe add an HGETALL to show the results of the HSET? Otherwise, more or less usable as it is.

I know we don't ultimately want the standard Hugo list of other pages in the section here, but it might be OK for now, since you've finished your bit quicker than I finished mine :-) Maybe just a short "see the pages below to learn more about developing with Redis", or something, and then the list? If you'd rather just wait until all the changes are ready, then that's fine by me, but this is so neat, it's probably a worthwhile improvement just as it is.

@dwdougherty
Copy link
Collaborator Author

@andy-stark-redis Please take another look.

@andy-stark-redis
Copy link
Contributor

@dwdougherty That's looking really good now! Maybe get Michelle's opinion too, but I'd say that's a neat improvement by itself, and mergeable right away :-)

@dwdougherty
Copy link
Collaborator Author

dwdougherty commented May 14, 2025

Hi @mich-elle-luna. These changes are the beginning of our work (@andy-stark-redis and yours truly) on a new landing page. Please take a look and let me know if it's okay to merge as is as an interim step while Andy completes the rest of the page.

@dwdougherty dwdougherty changed the title CLI test DEV: beginning of Develop landing page redesign May 14, 2025
Copy link
Collaborator

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dwdougherty
Copy link
Collaborator Author

Thank you, @mich-elle-luna and @andy-stark-redis!

@dwdougherty dwdougherty merged commit 321c0ec into main May 14, 2025
5 checks passed
@dwdougherty dwdougherty deleted the cli-test branch May 14, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants